Re: [patch 2/2] infiniband/cxgb4: add null check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Roland Dreier wrote:
 >  	if (status < 0) {
 > -		ep->com.cm_id->rem_ref(ep->com.cm_id);
 > +		if (ep->com.cm_id)
 > +			ep->com.cm_id->rem_ref(ep->com.cm_id);

Steve, does this make sense?
I actually think that ep->com.cm_id is always valid when connect_reply_upcall() is called. But I'd have to test it more. I'd rather not add this change unless someone convinces me that there actually is a path where the cm_id null...
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux