Looks fine to me... in fact I don't see how this could have avoided a NULL deref here unless the compiler is already optimizing out this assignment, since two lines above is struct sk_buff *skb = NULL; before we do - struct cpl_act_establish *rpl = cplhdr(skb); Steve? -- Roland Dreier <rolandd@xxxxxxxxx> || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html