On Tue, 1 Jun 2010, Dan Carpenter wrote: > This patch removes some unneeded code for if opt_dentry is null because > that can never happen. > > The function dereferences "opt_dentry" earlier when it checks > "if (opt_dentry->d_parent == opt_dentry) {". That code was added in > 2008. > > This function called from security_d_instantiate(). I checked all the > places which call security_d_instantiate() and dentry is always non-null. > I also checked the selinux version of this hook and there is a comment > which says that dentry should be non-null if called from > d_instantiate(). > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next -- James Morris <jmorris@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html