Julia Lawall wrote on 2010-05-22:
...
> --- a/drivers/ieee1394/video1394.c
> +++ b/drivers/ieee1394/video1394.c
> @@ -1045,14 +1045,9 @@ static long video1394_ioctl(struct file *file,
> if (get_user(qv, &p->packet_sizes))
> return -EFAULT;
>
> - psizes = kmalloc(buf_size, GFP_KERNEL);
> - if (!psizes)
> - return -ENOMEM;
> -
> - if (copy_from_user(psizes, qv, buf_size)) {
> - kfree(psizes);
> - return -EFAULT;
> - }
> + psizes = memdup_user(qv, buf_size);
> + if (IS_ERR(psizes))
> + return PTR_ERR(psizes);
> }
>
> spin_lock_irqsave(&d->lock,flags);
Committed to linux1394-2.6.git now, thanks. (Because akpm said that it
is worth it regardless of video1394 being at its end of life.)
--
Stefan Richter
-=====-==-=- -=-= =====
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
