On Sat, 29 May 2010 01:29:54 -0300, Mauro Carvalho Chehab wrote: > Em Sat, 22 May 2010 22:59:21 +0200 > Jean Delvare <khali@xxxxxxxxxxxx> escreveu: > > I would have used "(null)" instead of "<null>" for consistency with > > lib/vsprintf.c:string(). > > > > But more importantly, I suspect that a better fix would be to not call > > these macros when dev or ir, respectively, is NULL. The faulty dprintk > > calls in get_key_msi_tvanywhere_plus() and get_key_flydvb_trio() could > > be replaced with i2cdprintk (which is misnamed IMHO, BTW.) > > Agreed. > > Dan, could you please rework your patch according with Jean's feedback? He did already. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
