Hi Julia,
On Thu, May 27, 2010 at 02:37:39PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@xxxxxxx>
>
> The assignment seems completely unnecessary if mos7840_port is NULL.
>
[...]
> ---
> drivers/usb/serial/mos7840.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index f8424d1..585b7e6 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -730,7 +730,6 @@ static void mos7840_bulk_in_callback(struct urb *urb)
> mos7840_port = urb->context;
> if (!mos7840_port) {
> dbg("%s", "NULL mos7840_port pointer");
> - mos7840_port->read_urb_busy = false;
> return;
> }
I stumbled over this one a couple of weeks ago. There a patch sitting in
Greg's queue already:
http://thread.gmane.org/gmane.linux.usb.general/31668
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
