On Wed, May 26, 2010 at 10:48:08PM +0400, Denis Kirjanov wrote: > On Wed, May 26, 2010 at 20:28 +0400, Bashlykov Arthur wrote: > > - if (!ieee->proto_started){ > > + if (!ieee->proto_started) { > > ieee->iw_mode = wrqu->mode; > > I guess we can drop braces with single else statement How Bashlykov has this is proper kernel style because the else statement has more than one line. > > - }else{ > > + } else { > > ieee80211_stop_protocol(ieee); > > ieee->iw_mode = wrqu->mode; > > ieee80211_start_protocol(ieee); The rest of your comments were correct of course. Thanks for reviewing this patch. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html