On Tue, 25 May 2010 11:37:17 +0200 Dan Carpenter <error27@xxxxxxxxx> wrote: > In gsm_dlci_data_kick() we call gsm_dlci_data_sweep() with the > "gsm->tx_lock" held so we can't lock it again inside > gsm_dlci_data_sweep(). I removed that lock from and added one to > gsmld_write_wakeup() instead. The sweep function is only called from > those two places. Well spotted - I'm surprised that escaped as I've been using the code a fair bit in that exact form. Not immediately obvious that the case should be that hard to trigger. > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html