Re: [PATCH] checkpatch: warn on declaration with storage class not at the beginning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 20 May 2010 17:18:53 +0200, Tobias Klauser wrote:
> The C99 specification states in section 6.11.5:
> 
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
> 
> Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx>
> Cc: Jean Delvare <khali@xxxxxxxxxxxx>

Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>

> ---
>  scripts/checkpatch.pl |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index f2bbea9..4921473 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2586,6 +2586,11 @@ sub process {
>  			CHK("architecture specific defines should be avoided\n" .  $herecurr);
>  		}
>  
> +# Check that the storage class is at the beginning of a declaration
> +		if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
> +			WARN("storage class should be at the beginning of the declaration\n" . $herecurr)
> +		}
> +
>  # check the location of the inline attribute, that it is between
>  # storage class and type.
>  		if ($line =~ /\b$Type\s+$Inline\b/ ||


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux