On Fri, May 14, 2010 at 09:30:48PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > Use kstrdup when the goal of an allocation is copy a string into the > allocated region. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression from,to; > expression flag,E1,E2; > statement S; > @@ > > - to = kmalloc(strlen(from) + 1,flag); > + to = kstrdup(from, flag); > ... when != \(from = E1 \| to = E1 \) > if (to==NULL || ...) S > ... when != \(from = E2 \| to = E2 \) > - strcpy(to, from); > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> This patch is now in the merge-window branch of ocfs2.git. Joel -- "If you are ever in doubt as to whether or not to kiss a pretty girl, give her the benefit of the doubt" -Thomas Carlyle Joel Becker Principal Software Developer Oracle E-mail: joel.becker@xxxxxxxxxx Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
