At Fri, 14 May 2010 16:49:20 +0200, Dan Carpenter wrote: > > There is a typo here. We want to test "*dst" not "dst". > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Thanks. Applied (your other fix for asihpi, too). Takashi > diff --git a/sound/pci/asihpi/hpifunc.c b/sound/pci/asihpi/hpifunc.c > index 254c580..15f0c7e 100644 > --- a/sound/pci/asihpi/hpifunc.c > +++ b/sound/pci/asihpi/hpifunc.c > @@ -3279,7 +3279,7 @@ static u16 hpi_entity_alloc_and_copy(struct hpi_entity *src, > > buf_size = hpi_entity_size(src); > *dst = kmalloc(buf_size, GFP_KERNEL); > - if (dst == NULL) > + if (*dst == NULL) > return HPI_ERROR_MEMORY_ALLOC; > memcpy(*dst, src, buf_size); > return 0; > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html