From: Julia Lawall <julia@xxxxxxx> Use kstrdup when the goal of an allocation is copy a string into the allocated region. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression from,to; expression flag,E1,E2; statement S; @@ - to = kmalloc(strlen(from) + 1,flag); + to = kstrdup(from, flag); ... when != \(from = E1 \| to = E1 \) if (to==NULL || ...) S ... when != \(from = E2 \| to = E2 \) - strcpy(to, from); // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> --- fs/reiserfs/super.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff -u -p a/fs/reiserfs/super.c b/fs/reiserfs/super.c --- a/fs/reiserfs/super.c +++ b/fs/reiserfs/super.c @@ -1009,8 +1009,7 @@ static int reiserfs_parse_options(struct "on filesystem root."); return 0; } - qf_names[qtype] = - kmalloc(strlen(arg) + 1, GFP_KERNEL); + qf_names[qtype] = kstrdup(arg, GFP_KERNEL); if (!qf_names[qtype]) { reiserfs_warning(s, "reiserfs-2502", "not enough memory " @@ -1018,7 +1017,6 @@ static int reiserfs_parse_options(struct "quotafile name."); return 0; } - strcpy(qf_names[qtype], arg); *mount_options |= 1 << REISERFS_QUOTA; } else { if (qf_names[qtype] != -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
