Re: [patch] cifs: change && to ||

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 26, 2010 at 5:46 AM, Dan Carpenter <error27@xxxxxxxxx> wrote:
> On Mon, Apr 26, 2010 at 06:44:01AM -0400, Jeff Layton wrote:
>> On Mon, 26 Apr 2010 12:10:06 +0200
>> Dan Carpenter <error27@xxxxxxxxx> wrote:
>>
>> > This is a typo, if pvolume_info were NULL it would oops.
>> >
>> Good catch. I wonder though whether we can just eliminate that check
>> altogether? In any case, this is clearly correct in the short term.
>
> Nah, we can't.  If the kmalloc() that allocates *pvolume_info fails it
> would lead to an OOPs.
>
> regards,
> dan carpenter

Merged.


-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux