Hi Dan,
* Dan Carpenter <error27@xxxxxxxxx> [2010-04-26 13:36:27 +0200]:
> l2cap_create_connless_pdu() can sometimes return ERR_PTR(-ENOMEM) or
> ERR_PTR(-EFAULT).
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> ---
> In v2 I wrote the patch on top of Gustavo Padovon's devel tree
>
> diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
> index a668ef4..b32682c 100644
> --- a/net/bluetooth/l2cap.c
> +++ b/net/bluetooth/l2cap.c
> @@ -1712,8 +1712,12 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, struct ms
> /* Connectionless channel */
> if (sk->sk_type == SOCK_DGRAM) {
> skb = l2cap_create_connless_pdu(sk, msg, len);
> - l2cap_do_send(sk, skb);
> - err = len;
> + if (IS_ERR(skb)) {
> + err = PTR_ERR(skb);
Remove the braces on the 'if', then we are fine to pick your patch ;)
> + } else {
> + l2cap_do_send(sk, skb);
> + err = len;
> + }
> goto done;
> }
>
Regards,
--
Gustavo F. Padovan
http://padovan.org
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
