Dan Carpenter wrote:
> "chunk" can never be null here. We dereferenced it earlier in the
> function and also at the start of the function we passed it to
> sctp_pack_cookie() which dereferences it.
>
> This code has been around since the dawn of git history so if "chunk"
> were ever null someone would have complained about it.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>
> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index 17cb400..52352fc 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -470,8 +470,7 @@ struct sctp_chunk *sctp_make_init_ack(const struct sctp_association *asoc,
> *
> * [INIT ACK back to where the INIT came from.]
> */
> - if (chunk)
> - retval->transport = chunk->transport;
> + retval->transport = chunk->transport;
>
Actually, this code can be completely removed as we already make this assignment
earlier:
/* Per the advice in RFC 2960 6.4, send this reply to
* the source of the INIT packet.
*/
retval->transport = chunk->transport;
retval->subh.init_hdr =
sctp_addto_chunk(retval, sizeof(initack), &initack);
-vlad
> nomem_chunk:
> kfree(cookie);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
