On Wed, 21 April 2010 12:33:54 +0200, Dan Carpenter wrote: > > There is a typo here. We should test "last" instead of "first". > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/fs/logfs/super.c b/fs/logfs/super.c > index b60bfac..1e0449e 100644 > --- a/fs/logfs/super.c > +++ b/fs/logfs/super.c > @@ -377,7 +377,7 @@ static struct page *find_super_block(struct super_block *sb) > if (!first || IS_ERR(first)) > return NULL; > last = super->s_devops->find_last_sb(sb, &super->s_sb_ofs[1]); > - if (!last || IS_ERR(first)) { > + if (!last || IS_ERR(last)) { > page_cache_release(first); > return NULL; > } Applied, thanks! Did you use a tool to find this? And if yes, where would I find it? ;) Jörn -- In America you can have either a flimsy box banged together out of two by fours and drywall, or a McMansion -- a flimsy box banged together out of two by fours and drywall, but larger, more dramatic-looking, and full of expensive fittings. -- Paul Graham -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html