Hi Dan, On Sun, Mar 28, 2010 at 02:28:08PM +0300, Dan Carpenter wrote: > "pcf->irq_handler" has PCF50633_NUM_IRQ elements. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> Patch applied, many thanks. Cheers, Samuel. > diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c > index 03dcc92..4f13608 100644 > --- a/drivers/mfd/pcf50633-core.c > +++ b/drivers/mfd/pcf50633-core.c > @@ -217,7 +217,7 @@ static struct attribute_group pcf_attr_group = { > int pcf50633_register_irq(struct pcf50633 *pcf, int irq, > void (*handler) (int, void *), void *data) > { > - if (irq < 0 || irq > PCF50633_NUM_IRQ || !handler) > + if (irq < 0 || irq >= PCF50633_NUM_IRQ || !handler) > return -EINVAL; > > if (WARN_ON(pcf->irq_handler[irq].handler)) > @@ -234,7 +234,7 @@ EXPORT_SYMBOL_GPL(pcf50633_register_irq); > > int pcf50633_free_irq(struct pcf50633 *pcf, int irq) > { > - if (irq < 0 || irq > PCF50633_NUM_IRQ) > + if (irq < 0 || irq >= PCF50633_NUM_IRQ) > return -EINVAL; > > mutex_lock(&pcf->lock); -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html