On 04/01/2010 05:51 PM, Dan Carpenter wrote:
This should be spin_lock_irq() to match the spin_unlock_irq(). Originally it was a lock_kernel() but we switched everything to spin_lock_irq() last November. Signed-off-by: Dan Carpenter<error27@xxxxxxxxx> diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c index e0c5d2a..ecb2d8b 100644 --- a/drivers/char/mxser.c +++ b/drivers/char/mxser.c @@ -1768,7 +1768,7 @@ static int mxser_ioctl(struct tty_struct *tty, struct file *file, int len, lsr; len = mxser_chars_in_buffer(tty); - spin_lock(&info->slock); + spin_lock_irq(&info->slock);
Hmm, and there is one more error in the MOXA_ASPP_MON case. Interrupts are not disabled at all there. Could you fix that too?
Thanks. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
