On Mon, Mar 29, 2010 at 05:33:52PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > In the default case the lock is not unlocked. The return is > converted to a goto, to share the unlock at the end of the function. > > diff --git a/arch/s390/kernel/topology.c b/arch/s390/kernel/topology.c > index 14ef6f0..247b4c2 100644 > --- a/arch/s390/kernel/topology.c > +++ b/arch/s390/kernel/topology.c > @@ -165,10 +165,11 @@ static void tl_to_cores(struct tl_info *info) > default: > clear_cores(); > machine_has_topology = 0; > - return; > + goto out; > } > tle = next_tle(tle); > } > +out: > spin_unlock_irq(&topology_lock); Applied. Thank you! -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html