On Wed, Mar 24, 2010 at 09:46:23AM -0400, jamal wrote: > On Wed, 2010-03-24 at 14:47 +0300, Dan Carpenter wrote: > > The original code saved the error value but just returned 0 in the end. > > Looks reasonable and harmless. > If you have time - can you try this one test with your patch and see if > any strange message shows up when you delete? add a policy on window1, > on window2 run ip xfrm mon and then back on window1 delete it and watch > the event on window2 > > ---- > window2: ip xfrm mon > > window1, add: > ip xfrm policy add src 172.16.2.0/24 dst 172.16.1.0/24 \ > dir fwd ptype main \ > tmpl src 192.168.2.100 dst 192.168.1.100 \ > proto esp mode tunnel > > > window1, delete: > ip xfrm pol del src 172.16.2.0/24 dst 172.16.1.0/24 dir fwd > ---- Sure. I tried that and it looks OK. The truth is that I don't understand this code very well. I'm just writing patches based on static analysis. Here is the output from window1: $ sudo ip xfrm mon src 172.16.2.0/24 dst 172.16.1.0/24 dir fwd priority 0 tmpl src 192.168.2.100 dst 192.168.1.100 proto esp reqid 0 mode tunnel Deleted src 172.16.2.0/24 dst 172.16.1.0/24 dir fwd priority 0 tmpl src 192.168.2.100 dst 192.168.1.100 proto esp reqid 0 mode tunnel There aren't any messages in dmesg either. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
