On 03/20/10 14:13, Wolfram Sang wrote: > Fix I2C-drivers which missed setting clientdata to NULL before freeing the > structure it points to. Also fix drivers which do this _after_ the structure > was freed already. > > Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxx> Acked-by: Jonathan Cameron <jic23@xxxxxxxxx> Thanks, > --- > > Found using coccinelle, then reviewed. Full patchset is available via > kernel-janitors, linux-i2c, and LKML. > --- > drivers/staging/iio/adc/max1363_core.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c > index 9703881..1682fd0 100644 > --- a/drivers/staging/iio/adc/max1363_core.c > +++ b/drivers/staging/iio/adc/max1363_core.c > @@ -556,6 +556,7 @@ error_put_reg: > if (!IS_ERR(st->reg)) > regulator_put(st->reg); > error_free_st: > + i2c_set_clientdata(client, NULL); > kfree(st); > > error_ret: > @@ -573,6 +574,7 @@ static int max1363_remove(struct i2c_client *client) > regulator_disable(st->reg); > regulator_put(st->reg); > } > + i2c_set_clientdata(client, NULL); > kfree(st); > > return 0; -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
