On Sat, 20 Mar 2010, Dan Carpenter wrote: > Return ERR_PTR(-ENOMEM) if kmalloc() fails. We handle allocation > failures the same way later in the function. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c > index a260010..655b005 100644 > --- a/fs/ceph/mds_client.c > +++ b/fs/ceph/mds_client.c > @@ -328,6 +328,8 @@ static struct ceph_mds_session *register_session(struct ceph_mds_client *mdsc, > struct ceph_mds_session *s; > > s = kzalloc(sizeof(*s), GFP_NOFS); > + if (!s) > + return ERR_PTR(-ENOMEM); > s->s_mdsc = mdsc; > s->s_mds = mds; > s->s_state = CEPH_MDS_SESSION_NEW; Applied, thanks! sage -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html