On Thu, Mar 18, 2010 at 9:10 AM, Inaky Perez-Gonzalez <inaky.perez-gonzalez@xxxxxxxxx> wrote: > If krealloc() fails to aallocate a new pointer, the old block is > unmodified, so by doing this you are leaking a buffer allocation. It seems you are right. So now understanding correctly how krealloc() works I can see that the double kfree() can only actually happen if the el_size parameter to i2400m_zrealloc_2x() is zero, and it isn't at the two call sites. So this was a false positive and I am sorry for the noise. Darren J. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html