Re: [patch] hwmon: saving negative errors in unsigned

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 11 Mar 2010 12:08:32 +0100, Hans de Goede wrote:
> Ack.
> 
> Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Applied, thanks.

> On 03/11/2010 11:31 AM, Dan Carpenter wrote:
> > "ret" is used to store the return value for watchdog_trigger() and it
> > should be signed for the error handling to work.
> >
> > Signed-off-by: Dan Carpenter<error27@xxxxxxxxx>
> >
> > diff --git a/drivers/hwmon/w83793.c b/drivers/hwmon/w83793.c
> > index 9de81a4..612807d 100644
> > --- a/drivers/hwmon/w83793.c
> > +++ b/drivers/hwmon/w83793.c
> > @@ -1294,7 +1294,7 @@ static int watchdog_close(struct inode *inode, struct file *filp)
> >   static ssize_t watchdog_write(struct file *filp, const char __user *buf,
> >   	size_t count, loff_t *offset)
> >   {
> > -	size_t ret;
> > +	ssize_t ret;
> >   	struct w83793_data *data = filp->private_data;
> >
> >   	if (count) {


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux