On Mon, 2010-03-08 at 22:06 +0100, Christophe Jaillet wrote:
> From: Christophe Jaillet <christophe.jaillet@xxxxxxxxxx>
>
> Hi, here is a patch against arch/powerpc/platforms/pseries/ras.c.
>
> No need to memset (.., 0, ...) a buffer that is complety filled by a memcpy
> the line after.
>
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@xxxxxxxxxx>
>
> ---
>
> diff --git a/arch/powerpc/platforms/pseries/ras.c
> b/arch/powerpc/platforms/pseries/ras.c
> index 2b548af..7a401ed 100644
> --- a/arch/powerpc/platforms/pseries/ras.c
> +++ b/arch/powerpc/platforms/pseries/ras.c
> @@ -276,7 +276,6 @@ static struct rtas_error_log *fwnmi_get_errinfo(struct
> pt_regs *regs)
> (errdata >= rtas.base && errdata < rtas.base + rtas.size - 16)) {
> savep = __va(errdata);
> regs->gpr[3] = savep[0]; /* restore original r3 */
> - memset(mce_data_buf, 0, RTAS_ERROR_LOG_MAX);
> memcpy(mce_data_buf, (char *)(savep + 1), RTAS_ERROR_LOG_MAX);
While you are at it, this ^^^^^^^^ type cast is superfluous too.
> errhdr = (struct rtas_error_log *)mce_data_buf;
> } else {
Bernd
--
Bernd Petrovitsch Email : bernd@xxxxxxxxxxxxxxxxxxx
LUGA : http://www.luga.at
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
