On Sat, Mar 06, 2010 at 03:40:31PM +0100, Jan Ceuleers wrote: > Dan Carpenter wrote: > > Error handling? > > > The original code would break with a 4K stack. > > > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > --- > > This was compile tested only. Sorry about that. > > > > diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c > > index 1a79a6c..835758f 100644 > > --- a/net/bluetooth/hci_sysfs.c > > +++ b/net/bluetooth/hci_sysfs.c > > @@ -417,9 +417,11 @@ static ssize_t inquiry_cache_read(struct file *file, char __user *userbuf, > > struct hci_dev *hdev = file->private_data; > > struct inquiry_cache *cache = &hdev->inq_cache; > > struct inquiry_entry *e; > > - char buf[4096]; > > + char *buf; > > int n = 0; > > + ssize_t ret; > > > > + buf = kmalloc(4096, GFP_KERNEL); > > Could this kmalloc not fail? Grr... I'm really sorry about that. I will send an updated patch tomorrow. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
