Wed, Mar 03, 2010 at 09:46:10AM CET, error27@xxxxxxxxx wrote:
>The original code dereferenced "cpmac_mii" after calling
>"mdiobus_free(cpmac_mii);"
>
>Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>---
>Found by a static checker and not tested. Sorry. :/
>
>diff --git a/drivers/net/cpmac.c b/drivers/net/cpmac.c
>index b85c81f..9d48942 100644
>--- a/drivers/net/cpmac.c
>+++ b/drivers/net/cpmac.c
>@@ -1290,8 +1290,8 @@ void __devexit cpmac_exit(void)
> {
> platform_driver_unregister(&cpmac_driver);
> mdiobus_unregister(cpmac_mii);
>- mdiobus_free(cpmac_mii);
> iounmap(cpmac_mii->priv);
>+ mdiobus_free(cpmac_mii);
> }
>
> module_init(cpmac_init);
Looks good. Thanks.
Reviewed-by: Jiri Pirko <jpirko@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
