Re: [patch] staging: vt6655: add missing curly braces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Dan Carpenter schrieb:
> It's clear from the indent levels and the context that there are supposed to
> be curly braces here.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> 
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index db78614..bf4fd49 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -2788,16 +2788,18 @@ void CARDvUpdateBasicTopRate (PVOID pDeviceHandler)
>  
>       //Determines the highest basic rate.
>       for (ii = RATE_54M; ii >= RATE_6M; ii --) {
> -         if ( (pDevice->wBasicRate) & ((WORD)(1<<ii)) )
> +         if ( (pDevice->wBasicRate) & ((WORD)(1<<ii)) ) {
>               byTopOFDM = ii;
>               break;
> +         }
>       }
>       pDevice->byTopOFDMBasicRate = byTopOFDM;
>  
>       for (ii = RATE_11M;; ii --) {
> -         if ( (pDevice->wBasicRate) & ((WORD)(1<<ii)) )
> +         if ( (pDevice->wBasicRate) & ((WORD)(1<<ii)) ) {
>               byTopCCK = ii;
>               break;
> +         }
>           if (ii == RATE_1M)
>              break;
>       }


this is a realy nice catch :)
NTL i guess the code is looking for the highest bit that could be replace
with kernel code. (ffs() ?)

just my 2 cents,
 wh
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux