rdma_request() is supposed to return negative values on error. This change means that if a kmalloc() fails it returns -ENOMEM. The original code returned certain negative values, zero on success and zero on kmalloc() failures. Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> --- I was just reading the code and I noticed this bug. I haven't tested it because I don't have the hardware. diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c index 2c95a89..589e340 100644 --- a/net/9p/trans_rdma.c +++ b/net/9p/trans_rdma.c @@ -419,7 +419,7 @@ static int rdma_request(struct p9_client *client, struct p9_req_t *req) struct p9_trans_rdma *rdma = client->trans; struct ib_send_wr wr, *bad_wr; struct ib_sge sge; - int err = 0; + int err = -ENOMEM; unsigned long flags; struct p9_rdma_context *c = NULL; struct p9_rdma_context *rpl_context = NULL; -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
