On Mon, Jan 25, 2010 at 12:41:54PM -0800, Greg KH wrote: > On Mon, Jan 25, 2010 at 02:53:33PM +0300, Dan Carpenter wrote: > > Johan Hovold points out that get_string() is basically just a re-implimentation > > of usb_string(). It is also buggy. It does DMA on the stack and it doesn't > > handle negative returns from usb_get_descriptor(). Plus unicode_to_ascii() is > > a rubbish function and moving to usb_string() avoids using it. > > > > Let's eliminate get_string() entirely. > > > > Reported-by: Johan Hovold <jhovold@xxxxxxxxx> > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > Cc: stable@xxxxxxxxxx > > Why stable? Does this fix an existing bug somewhere? > No sorry. My script added that automatically and I meant forgot to remove it. This should go through -next I think. I will be more careful in the future. regards, dan carpenter > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
