On Mon, Jan 25, 2010 at 02:53:33PM +0300, Dan Carpenter wrote: > Johan Hovold points out that get_string() is basically just a re-implimentation > of usb_string(). It is also buggy. It does DMA on the stack and it doesn't > handle negative returns from usb_get_descriptor(). Plus unicode_to_ascii() is > a rubbish function and moving to usb_string() avoids using it. > > Let's eliminate get_string() entirely. Hm, for some reason I couldn't use usb_string() when I originally wrote this code (way back in 1999). I can't recall what it is, but have you tested this with an edgeport device to verify that it doesn't break anything? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
