Acked-by: Jing Huang <huangj@xxxxxxxxxxx> > -----Original Message----- > From: Julia Lawall [mailto:julia@xxxxxxx] > Sent: Saturday, January 16, 2010 7:59 AM > To: Jing Huang; James E.J. Bottomley; linux-scsi@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: [PATCH 5/9] drivers/scsi: Eliminate useless code > > From: Julia Lawall <julia@xxxxxxx> > > The variable bfa_itnim is initialized twice to the same (side effect-free) > expression. Drop one initialization. > > A simplified version of the semantic match that finds this problem is: > (http://coccinelle.lip6.fr/) > > // <smpl> > @forall@ > idexpression *x; > identifier f!=ERR_PTR; > @@ > > x = f(...) > ... when != x > ( > x = f(...,<+...x...+>,...) > | > * x = f(...) > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- > drivers/scsi/bfa/bfad_im.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c > index f788c2a..37b0fa1 100644 > --- a/drivers/scsi/bfa/bfad_im.c > +++ b/drivers/scsi/bfa/bfad_im.c > @@ -243,9 +243,8 @@ bfad_im_target_reset_send(struct bfad_s *bfad, struct > scsi_cmnd *cmnd, > struct bfa_itnim_s *bfa_itnim; > bfa_status_t rc = BFA_STATUS_OK; > > - bfa_itnim = bfa_fcs_itnim_get_halitn(&itnim->fcs_itnim); > tskim = bfa_tskim_alloc(&bfad->bfa, (struct bfad_tskim_s *) cmnd); > if (!tskim) { > BFA_DEV_PRINTF(bfad, BFA_ERR, -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
