Am Montag 18 Januar 2010 20:17:49 schrieb Joe Perches: > On Mon, 2010-01-18 at 19:34 +0100, Peter Hüwe wrote: > > From: Peter Huewe <peterhuewe@xxxxxx> > > Date: Mon, 18 Jan 2010 19:21:02 +0100 > > This patch fixes all 77 errors reported by checkpatch - no functional > > change was made. The line over 80 chars warnings were left untouched. > > diff --git a/drivers/video/matrox/matroxfb_crtc2.c > > b/drivers/video/matrox/matroxfb_crtc2.c index 78414ba..790ca47 100644 > > --- a/drivers/video/matrox/matroxfb_crtc2.c > > +++ b/drivers/video/matrox/matroxfb_crtc2.c > > @@ -42,42 +43,41 @@ static int matroxfb_dh_setcolreg(unsigned regno, > > unsigned red, unsigned green, blue = CNVT_TOHW(blue, > > m2info->fbcon.var.blue.length); > > transp = CNVT_TOHW(transp, m2info->fbcon.var.transp.length); > > > > - col = (red << m2info->fbcon.var.red.offset) | > > - (green << m2info->fbcon.var.green.offset) | > > - (blue << m2info->fbcon.var.blue.offset) | > > - (transp << m2info->fbcon.var.transp.offset); > > + col = (red << m2info->fbcon.var.red.offset) | > > + (green << m2info->fbcon.var.green.offset) | > > + (blue << m2info->fbcon.var.blue.offset) | > > + (transp << m2info->fbcon.var.transp.offset); > > I think this is not an improvement. > Hi, the reason behind this change was that spaces and tabs were mixed for indention. - col = (red << m2info->fbcon.var.red.offset) | - (green << m2info->fbcon.var.green.offset) | - (blue << m2info->fbcon.var.blue.offset) | - (transp << m2info->fbcon.var.transp.offset); + col = (red << m2info->fbcon.var.red.offset) | + (green << m2info->fbcon.var.green.offset) | + (blue << m2info->fbcon.var.blue.offset) | + (transp << m2info->fbcon.var.transp.offset); How about this indention? Would this be better? I'll wait for your response and wrap up the other changes then and resubmit it. Thanks for your comments! Peter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
