From: Julia Lawall <julia@xxxxxxx> Date: Sat, 16 Jan 2010 16:57:56 +0100 (CET) > The variable qdev is initialized twice to the same (side effect-free) > expression. Drop one initialization. > > A simplified version of the semantic match that finds this problem is: > (http://coccinelle.lip6.fr/) > > // <smpl> > @forall@ > idexpression *x; > identifier f!=ERR_PTR; > @@ > > x = f(...) > ... when != x > ( > x = f(...,<+...x...+>,...) > | > * x = f(...) > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> Something in your patch creation process is corrupting these patches. > diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c > index f922294..4ef0afb 100644 > --- a/drivers/net/qla3xxx.c > +++ b/drivers/net/qla3xxx.c > @@ -4087,9 +4087,8 @@ static void __devexit ql3xxx_remove(struct pci_dev *pdev) > struct ql3_adapter *qdev = netdev_priv(ndev); > > unregister_netdev(ndev); > - qdev = netdev_priv(ndev); > > ql_disable_interrupts(qdev); > > -- That hunk header states that after the line is removed there should be 8 lines present in the hunk, but the patch only shows 7 such lines. I suspect something is eating the final line of your patches. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
