On Thu, 12 Nov 2009, Anders Larsen wrote: > From: Julia Lawall <julia@xxxxxxx> > > As an identical match is wanted in this case, strcmp can be used instead. > > The semantic match that lead to detecting this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression foo; > constant char *abc; > @@ > > *strncmp(foo, abc, sizeof(abc)) > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > Signed-off-by: Anders Larsen <al@xxxxxxxxxxx> > > --- > fs/qnx4/inode.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/fs/qnx4/inode.c b/fs/qnx4/inode.c > index 449f5a6..150f4af 100644 > --- a/fs/qnx4/inode.c > +++ b/fs/qnx4/inode.c > @@ -221,7 +221,8 @@ static const char *qnx4_checkroot(struct super_block *sb) > rootdir = (struct qnx4_inode_entry *) (bh->b_data + i * QNX4_DIR_ENTRY_SIZE); > if (rootdir->di_fname != NULL) { > QNX4DEBUG((KERN_INFO "rootdir entry found : [%s]\n", rootdir->di_fname)); > - if (!strncmp(rootdir->di_fname, QNX4_BMNAME, sizeof QNX4_BMNAME)) { > + if (!strcmp(rootdir->di_fname, > + QNX4_BMNAME)) { > found = 1; > qnx4_sb(sb)->BitMap = kmalloc( sizeof( struct qnx4_inode_entry ), GFP_KERNEL ); > if (!qnx4_sb(sb)->BitMap) { Doesn't seem to be present in 2.6.33-rc1. Applied to my queue, thanks. -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
