On Fri, Dec 04, 2009 at 06:19:29PM -0800, Radu Voicilas wrote: > 1. When you have a function prototype with a comment following it (which obviously it's a bad thing), like this one > > u32 eprom_read(struct net_device *dev,u32 addr); //reads a 16 bits word > > and want to fix it, how would one do it: > > /* Read a 16 bits word. */ > u32 eprom_read(struct net_device *dev, u32 addr); > > or the comment should go into the implementation file ? It should go in the implementation file, but common sense is always best. Be sure to read Documentation/CodingStyle. Davidlohr -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html