On Sun, 13 Dec 2009 13:52:59 +0100 Florian Tobias Schandinat <FlorianSchandinat@xxxxxx> wrote: > Hi Julia, Andrew, > > Julia Lawall schrieb: > > From: Julia Lawall <julia@xxxxxxx> > > > > sizeof(viafb_gamma_table) is just the size of the pointer. This is changed > > to the size used when calling kmalloc to initialize the pointer. > > this is the second patch addressing this issue ending up in my mailbox. > At least this one is technically correct so feel free to upstream it. > However I vote for removing this ioctl hell from viafb as most of them > duplicate framebuffer functionality or have unknown (not clearly > defined) functionality or at least solve a generic problem with a custom > ioctl (which I consider bad). I had a patch ready to move this stuff to > an extra file and print a warning that it is subject to be removed. I > feel a bit uncomfortable about repairing broken stuff prior to removing it. > Any comments on this subject? > I favour both repairing and removing broken stuff ;) We may as well fix it if problems are known. Perhaps someone is hitting the problem at runtime in an older kernel and needs a patch to backport. Perhaps we later decide to revert the removal, thus reinstating the known bug. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
