Matthew Wilcox wrote: > On Mon, Oct 19, 2009 at 11:08:41PM +0200, "L. Alberto Gim??nez" wrote: > I think in this particular case, there's no reason for 'boot_trace_call' > to have file-level scope. I would move it inside the do_one_initcall() > function (and I'd do the same with msgbuf and boot_trace_ret too). Matthew, Walter, thanks for your reply. The static (file-scope) variable was introduced by Ingo Molnar in commit 4a683bf9. It seems that originally those three static variables were local variables, what turned out to cause a stack overflow. So, I think they will stay just like they are right now :) (thank god we have git-blame). Instead, I'll try to work on renaming the "offending" local variables and cleaning file by file sparse warnings. Best regards, -- L. Alberto Giménez GnuPG key ID 0x3BAABDE1 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
