> > Thanks for the patch. By the way, what tree is this against, or did you > just see my patch on a mailing list? > It is against yesterday linux-next tree. > > Unfortunately, this patch has some issues. It's a bit nasty to do real > work inside of if() conditions, especially when you already have a nice, > local variable to store the condition for you. > > Your patch is also buggy because the out: label tries to disable the > device and clean up the 'struct device'. Neither of those things has > been done if the pci_enable_device() fails in the first place. It will > probably oops. > I see. > I'll cc you on what I think is the correct patch. > > -- Dave > > Thank you very much and sorry for the noise -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
