Or perhaps it is the request_region that is incorrect, since the same value is later used with ioremap? julia On Sun, 9 Aug 2009, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > request_region should be used with release_region, not request_mem_region. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @r1@ > expression start; > @@ > > request_region(start,...) > > @b1@ > expression r1.start; > @@ > > request_mem_region(start,...) > > @depends on !b1@ > expression r1.start; > expression E; > @@ > > - release_mem_region > + release_region > (start,E) > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- > drivers/isdn/hisax/isurf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/drivers/isdn/hisax/isurf.c b/drivers/isdn/hisax/isurf.c > --- a/drivers/isdn/hisax/isurf.c > +++ b/drivers/isdn/hisax/isurf.c > @@ -125,7 +125,7 @@ release_io_isurf(struct IsdnCardState *c > { > release_region(cs->hw.isurf.reset, 1); > iounmap(cs->hw.isurf.isar); > - release_mem_region(cs->hw.isurf.phymem, ISURF_IOMEM_SIZE); > + release_region(cs->hw.isurf.phymem, ISURF_IOMEM_SIZE); > } > > static void > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
