Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > Elsewhere the sin_family field holds a value with a name of the form > AF_..., so it seems reasonable to do so here as well. Also the values of > PF_INET and AF_INET are the same. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > struct sockaddr_in sip; > @@ > > ( > sip.sin_family == > - PF_INET > + AF_INET > | > sip.sin_family != > - PF_INET > + AF_INET > | > sip.sin_family = > - PF_INET > + AF_INET > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > Acked-by: Casey Schaufler <casey@xxxxxxxxxxxxxxxx> Yes, this is a correction. Thank you. > --- > security/smack/smack_lsm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c > --- a/security/smack/smack_lsm.c > +++ b/security/smack/smack_lsm.c > @@ -2464,7 +2464,7 @@ static int smack_socket_sendmsg(struct s > /* > * Perfectly reasonable for this to be NULL > */ > - if (sip == NULL || sip->sin_family != PF_INET) > + if (sip == NULL || sip->sin_family != AF_INET) > return 0; > > return smack_netlabel_send(sock->sk, sip); > -- > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
