From: Julia Lawall <julia@xxxxxxx> backlight_device_register may return an ERR_PTR value rather than a valid pointer. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier fld,fld1; expression x,E; @@ x = backlight_device_register(...) ... when != x = E when != &x when != x->fld1 ( ((IS_ERR(x))||...) | * x->fld ) // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> --- drivers/acpi/video.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index 8851315..29788db 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -982,6 +982,8 @@ static void acpi_video_device_find_cap(struct acpi_video_device *device) sprintf(name, "acpi_video%d", count++); device->backlight = backlight_device_register(name, NULL, device, &acpi_backlight_ops); + if (IS_ERR(device->backlight)) + return; device->backlight->props.max_brightness = device->brightness->count-3; kfree(name); -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
