On Tuesday 28 July 2009, Nicolas Palix wrote: > Remove typedef DEVICE_OBJECT and use a struct with the same name > instead. The new struct name uses lower case (struct device_object). > > Remove typedef PDEVICE_OBJECT which aliases a pointer and use the > corresponding renamed struct pointer (struct device_object *). > > Here is the semantic patch generated to perform this transformation: > (http://www.emn.fr/x-info/coccinelle/) > The patch looks technically correct and improves the code, but I'd suggest renaming the structure to fall into a proper namespace. The name device_object is extremely generic and should not be defined as part of a single driver. Simply putting it into a namespace here would make it hv_device_object, or even mshv_device_object ('hv' still is very generic), but then the 'object' part is still redundant. Since it is part of the 'vmbus' layer, how about naming it 'struct vmbus_device'? Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html