From: Jay Vosburgh <fubar@xxxxxxxxxx> Date: Sat, 11 Jul 2009 13:03:55 -0700 > > From: Julia Lawall <julia@xxxxxxx> > > AD_SHORT_TIMEOUT and AD_STATE_LACP_ACTIVITY have the same value, but > AD_STATE_LACP_ACTIVITY better reflects the intended semantics. > > [ J adds: AD_STATE_LACP_ACTIVITY is a value defined by the standard, and > should be set here in accordance with 802.3ad 43.4.12; AD_SHORT_TIMEOUT > is a constant specific to the Linux 802.3ad implementation that happens > to have the same value ] > > The semantic match that finds this problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @@ > struct port_params p; > @@ > * p.port_state |= AD_SHORT_TIMEOUT > // </smpl> > > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > Signed-off-by: Jay Vosburgh <fubar@xxxxxxxxxx> Applied. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
