On Tue, Jul 7, 2009 at 23:36, Florian Fainelli<florian@xxxxxxxxxxx> wrote:
> Remove duplicated #include('s) in drivers/vlynq/vlynq.c
The following little script catches more of these issues, though it
might be a bit fragile:
#!/bin/bash
find . -name "*.c" | \
while read file; do
dblinc=$(grep "^#include <" $file | sort | uniq -c | grep -v "^ 1 ")
[ "$dblinc" != "" ] && echo $file: $dblinc
done
when ran from the linux-2.6 src tree, the output is something like
(lines starting with '#' are my annotations):
./mm/slab.c: 3 #include <linux/kmalloc_sizes.h>
# this is a false positive
./mm/slqb.c: 2 #include <linux/seq_file.h>
# I did not look a this one
./mm/shmem.c: 2 #include <linux/vfs.h>
# this is a hit
# the rest (about 50 hits) skipped
Do you want to investigate this issues?
Cheers,
Hannes
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
