Paul Mundt schrieb: > On Wed, May 20, 2009 at 11:30:21AM +0100, Andr? Lopes wrote: >> Hi. This is my first post :-) >> >> I was reading this doc (/linux-2.6/Documentation/scsi/ChangeLog.lpfc), >> when I found this phrase: "Replace some kfree((void*)ptr) with >> kfree(ptr)." >> > [snip] > >> These casts are not necessary...I think so. If it's yes, can we apply >> patch's to clean-up this? >> > The key thing here is "ptr", as long as these are pointers, then the cast > is superfluous. In the case of casting from a non-pointer type, the cast > is necessary, particularly if the data type and pointer size vary. i think the problem is clear, since he ask for advice.. IMHO i would start with identifying adding a marker like /* cast needed ...*/, perhaps creating a myfree(propper type). that would document the use and prevent other people from converting. just my 2 cents, re, wh -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
