On Thu, 7 May 2009, walter harms wrote:
> Robert P. J. Day schrieb:
> > The "ramdisk" parameter was removed from the defunct rd.c file quite
> > some time ago, in favour of the more specific "ramdisk_size"
> > parameter so, for consistency, the same should be done here.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> >
> > ---
> >
> > the earlier removal was in fac8b209b1084bc85748bd54e13d00c1262b220f.
> >
> > diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> > index 5f7e64b..4bf8705 100644
> > --- a/drivers/block/brd.c
> > +++ b/drivers/block/brd.c
> > @@ -407,12 +407,7 @@ static int __init ramdisk_size(char *str)
> > rd_size = simple_strtol(str, NULL, 0);
> > return 1;
> > }
> > -static int __init ramdisk_size2(char *str)
> > -{
> > - return ramdisk_size(str);
> > -}
> > -__setup("ramdisk=", ramdisk_size);
> > -__setup("ramdisk_size=", ramdisk_size2);
> > +__setup("ramdisk_size=", ramdisk_size);
> > #endif
> >
> > /*
> >
>
>
> i do not use this parameter but people will be confused if it suddenly vanish.
> IMHO it would be better to add something like
>
> printk(KERN_ERR "'ramdisk=' will be removed with kernel 2.6.35 ....";
>
> pleae note there is a clear kernel number what will put pressure on everyone
> really to remove the parameter.
>
> just my two cents,
> wh
that deprecated parameter was removed entirely in an earlier patch i
submitted (see above), and everyone signed off on it. so it seems
unlikely to cause major problems to remove it a second time after it
was re-introduced, but i'll leave that decision to others.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Linked In: http://www.linkedin.com/in/rpjday
Twitter: http://twitter.com/rpjday
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
