On Wed, Apr 8, 2009 at 14:02, Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote: > On Wed, Apr 8, 2009 at 13:22, Jack Stone <jwjstone@xxxxxxxxxxx> wrote: >> Remove uneeded void casts >> >> Signed-Off-By: Jack Stone <jwjstone@xxxxxxxxxxx> >> --- >> fs/sysv/dir.c | 14 +++++++------- >> 1 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/fs/sysv/dir.c b/fs/sysv/dir.c >> index 56f6552..8a9f5a7 100644 >> --- a/fs/sysv/dir.c >> +++ b/fs/sysv/dir.c >> @@ -367,7 +367,7 @@ struct sysv_dir_entry * sysv_dotdot (struct inode *dir, struct page **p) >> struct sysv_dir_entry *de = NULL; >> >> if (!IS_ERR(page)) { >> - de = (struct sysv_dir_entry*) page_address(page) + 1; >> + de = page_address(page) + 1; > This is probably wrong, because (void* + 1) != (struct sysv_dir_entry* + 1). > Yeah, with this in mind I need to check all your patches again ;-) >> *p = page; >> } >> return de; >> -- > > Bert > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html