looks good, except for a tiny nit-pick: > +++ b/fs/xfs/support/debug.c > @@ -19,6 +19,7 @@ > #include "debug.h" > > /* xfs_mount.h drags a lot of crap in, sorry.. */ > +#include "xfs_error.h" > #include "xfs_sb.h" > #include "xfs_inum.h" > #include "xfs_ag.h" as xfs_mount.h doesn't require xfs_error.h it should be included above that comment. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html