Stefan Richter wrote: > Hannes Eder wrote: >> On Sun, Feb 22, 2009 at 12:30 PM, Stefan Richter >> <stefanr@xxxxxxxxxxxxxxxxx> wrote: >>> It is not a fix, it's merely an annotation. >> This patch 'better word for fix's a warning reported by sparse. What >> better wording would you suggest? > > "annotate init_post() as releasing the BKL" or whatever in the title, > furthermore "Removes the following sparse warnings: ..." in the changelog. PS: In some sense it is indeed a "fix" for the high-level problem that sparse can't guess whether the context imbalance is correct or not. The original warning from sparse was correct in itself. Your annotation enables sparse to warn if problems outside the scope of the single function occur (I guess). So it's more a maintainabiliy improvement than a fix. -- Stefan Richter -=====-==--= --=- =-==- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
